null_blk: use async queue restart helper
authorJens Axboe <axboe@fb.com>
Mon, 28 Dec 2015 20:02:47 +0000 (13:02 -0700)
committerJens Axboe <axboe@fb.com>
Mon, 28 Dec 2015 20:07:09 +0000 (13:07 -0700)
If null_blk is run in NULL_IRQ_TIMER mode and with queue_mode NULL_Q_RQ,
we need to restart the queue from the hrtimer interrupt. We can't
directly invoke the request_fn from that context, so punt the queue run
to async kblockd context.

Tested-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/null_blk.c

index a428e4ef71fd74ce2d569b9cfd407a7f6b0e3eb0..09e3c0d87eccff2d526666b99d3036f3921662a8 100644 (file)
@@ -232,20 +232,19 @@ static void end_cmd(struct nullb_cmd *cmd)
                break;
        case NULL_Q_BIO:
                bio_endio(cmd->bio);
-               goto free_cmd;
+               break;
        }
 
+       free_cmd(cmd);
+
        /* Restart queue if needed, as we are freeing a tag */
-       if (q && !q->mq_ops && blk_queue_stopped(q)) {
+       if (queue_mode == NULL_Q_RQ && blk_queue_stopped(q)) {
                unsigned long flags;
 
                spin_lock_irqsave(q->queue_lock, flags);
-               if (blk_queue_stopped(q))
-                       blk_start_queue(q);
+               blk_start_queue_async(q);
                spin_unlock_irqrestore(q->queue_lock, flags);
        }
-free_cmd:
-       free_cmd(cmd);
 }
 
 static enum hrtimer_restart null_cmd_timer_expired(struct hrtimer *timer)