perf annotate: Fix storing per line sym_hist_entry
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 28 Jul 2017 15:49:02 +0000 (12:49 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 28 Jul 2017 15:53:05 +0000 (12:53 -0300)
The existing loop incremented the offset while using it as the array
index, when we went to an array of sym_hist_entry instances, we
should've moved the increment to outside of the array element reference,
oops, fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Taeung Song <treeze.taeung@gmail.com>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: 461c17f00f40 ("perf annotate: Store the sample period in each histogram bucket")
Link: http://lkml.kernel.org/n/tip-s3dm6uyrazlpag3f0psfia07@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/annotate.c

index 5125c2bbacaa06bddbec9c7ba5c9fa04c78f551c..2dab0e5a7f2f0ea448b2041a4d60b082d2da8129 100644 (file)
@@ -963,8 +963,9 @@ double disasm__calc_percent(struct annotation *notes, int evidx, s64 offset,
                u64 period = 0;
 
                while (offset < end) {
-                       hits += h->addr[offset++].nr_samples;
-                       period += h->addr[offset++].period;
+                       hits   += h->addr[offset].nr_samples;
+                       period += h->addr[offset].period;
+                       ++offset;
                }
 
                if (h->nr_samples) {