cifs: fix revalidation test in cifs_llseek()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 30 Apr 2012 14:36:21 +0000 (17:36 +0300)
committerSteve French <sfrench@us.ibm.com>
Wed, 9 May 2012 20:16:22 +0000 (15:16 -0500)
This test is always true so it means we revalidate the length every
time, which generates more network traffic.  When it is SEEK_SET or
SEEK_CUR, then we don't need to revalidate.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/cifsfs.c

index ca6a3796a33bb0640b6444891713196834340eb4..541ef81f6ae8ffe99ebcfa9c303f9c15975dd8c7 100644 (file)
@@ -699,7 +699,7 @@ static loff_t cifs_llseek(struct file *file, loff_t offset, int origin)
         * origin == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate
         * the cached file length
         */
-       if (origin != SEEK_SET || origin != SEEK_CUR) {
+       if (origin != SEEK_SET && origin != SEEK_CUR) {
                int rc;
                struct inode *inode = file->f_path.dentry->d_inode;