drm/vc4: use drm_for_each_connector_iter()
authorGustavo Padovan <gustavo.padovan@collabora.com>
Fri, 12 May 2017 16:41:00 +0000 (13:41 -0300)
committerGustavo Padovan <gustavo.padovan@collabora.com>
Fri, 26 May 2017 05:12:44 +0000 (02:12 -0300)
Drop legacy drm_for_each_connector() in favor of the race-free
drm_for_each_connector_iter().

v2: add missing drm_connector_list_iter_end(Daniel Vetter)

Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Eric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/20170512164100.7649-1-gustavo@padovan.org
drivers/gpu/drm/vc4/vc4_crtc.c

index 0bfc4d88e4c23c0b7ce2522a98f63f399a833873..403bbd5f99a9fa97c025f60be11e31a6e043027e 100644 (file)
@@ -345,12 +345,16 @@ static u32 vc4_get_fifo_full_level(u32 format)
 static struct drm_encoder *vc4_get_crtc_encoder(struct drm_crtc *crtc)
 {
        struct drm_connector *connector;
+       struct drm_connector_list_iter conn_iter;
 
-       drm_for_each_connector(connector, crtc->dev) {
+       drm_connector_list_iter_begin(crtc->dev, &conn_iter);
+       drm_for_each_connector_iter(connector, &conn_iter) {
                if (connector->state->crtc == crtc) {
+                       drm_connector_list_iter_end(&conn_iter);
                        return connector->encoder;
                }
        }
+       drm_connector_list_iter_end(&conn_iter);
 
        return NULL;
 }