projects / GitHub / LineageOS / android_kernel_samsung_universal7580.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 8e039d8)
ksz884x: fix return value of netdev_set_eeprom
authorJens Rottmann <JRottmann@LiPPERTEmbedded.de>
Tue, 23 Mar 2010 04:23:50 +0000 (04:23 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Mar 2010 20:06:15 +0000 (13:06 -0700)
ksz884x: fix return value of netdev_set_eeprom

netdev_set_eeprom() confused ethtool by just returning 1 on error
instead of a proper -EINVAL.

Signed-off-by: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ksz884x.c patch | blob | blame | history

diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 0f59099ee72f8d504d314ef41af592d377f58795..6c5327af1bf920e28f7291c7ce9bb47aac8eafde 100644 (file)
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -6322,7 +6322,7 @@ static int netdev_set_eeprom(struct net_device *dev,
        int len;
 
        if (eeprom->magic != EEPROM_MAGIC)
-               return 1;
+               return -EINVAL;
 
        len = (eeprom->offset + eeprom->len + 1) / 2;
        for (i = eeprom->offset / 2; i < len; i++)