usb: gadget: uvc: remove references to DMA_ADDR_INVALID
authorFelipe Balbi <balbi@ti.com>
Thu, 14 Mar 2013 08:48:02 +0000 (10:48 +0200)
committerFelipe Balbi <balbi@ti.com>
Mon, 18 Mar 2013 09:18:12 +0000 (11:18 +0200)
gadget drivers shouldn't touch req->dma at all,
since UDC drivers are the ones required to handle
mapping and unmapping of the request buffer.

Remove references to DMA_ADDR_INVALID so we don't
creat false expectations to gadget driver writers.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/uvc.h
drivers/usb/gadget/uvc_v4l2.c
drivers/usb/gadget/uvc_video.c

index 93b0c11911150a8b42a2c46915d273626f9aec85..7e90b1d12d09f646cc5fd0dce2530e7301d25fef 100644 (file)
@@ -98,8 +98,6 @@ extern unsigned int uvc_gadget_trace_param;
 #define DRIVER_VERSION                         "0.1.0"
 #define DRIVER_VERSION_NUMBER                  KERNEL_VERSION(0, 1, 0)
 
-#define DMA_ADDR_INVALID                       (~(dma_addr_t)0)
-
 #define UVC_NUM_REQUESTS                       4
 #define UVC_MAX_REQUEST_SIZE                   64
 #define UVC_MAX_EVENTS                         4
index 2ca9386d655bc69fa5b02f55b14e5bcae3b0d4ad..0080d073bd5e2e283ab49dee94f812ce31977c71 100644 (file)
@@ -41,7 +41,6 @@ uvc_send_response(struct uvc_device *uvc, struct uvc_request_data *data)
 
        req->length = min_t(unsigned int, uvc->event_length, data->length);
        req->zero = data->length < uvc->event_length;
-       req->dma = DMA_ADDR_INVALID;
 
        memcpy(req->buf, data->data, data->length);
 
index b0e53a8ea4f7a68ea1156e2446dfbda401bcd1d2..885c393ee470f39b5e26ef63d46b29321f269981 100644 (file)
@@ -245,7 +245,6 @@ uvc_video_alloc_requests(struct uvc_video *video)
 
                video->req[i]->buf = video->req_buffer[i];
                video->req[i]->length = 0;
-               video->req[i]->dma = DMA_ADDR_INVALID;
                video->req[i]->complete = uvc_video_complete;
                video->req[i]->context = video;