fcoe: use continue instead of goto+label
authorJiri Slaby <jslaby@suse.cz>
Tue, 6 Oct 2015 12:27:45 +0000 (14:27 +0200)
committerJames Bottomley <JBottomley@Odin.com>
Tue, 10 Nov 2015 01:06:37 +0000 (17:06 -0800)
There is a label pointing to the start of a while loop and a goto
nested only in the loop. The goto jumps to the label in some cases.
Replace the goto and the label by simple continue.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/fcoe/fcoe.c

index d3eb80c46bbe2224ac9cd82b2e3833f28e7ab297..d187ba9b361da070429d9e16c723b7d5569405cb 100644 (file)
@@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
 
        set_user_nice(current, MIN_NICE);
 
-retry:
        while (!kthread_should_stop()) {
 
                spin_lock_bh(&p->fcoe_rx_list.lock);
@@ -1883,7 +1882,7 @@ retry:
                        set_current_state(TASK_INTERRUPTIBLE);
                        spin_unlock_bh(&p->fcoe_rx_list.lock);
                        schedule();
-                       goto retry;
+                       continue;
                }
 
                spin_unlock_bh(&p->fcoe_rx_list.lock);