usb: gadget: dummy_hcd: fix error return code in init()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 7 May 2013 11:50:06 +0000 (19:50 +0800)
committerFelipe Balbi <balbi@ti.com>
Wed, 15 May 2013 14:25:31 +0000 (17:25 +0300)
Fix to return -ENOMEM in the kzalloc() error handling case instead
of 0(following platform_device_add_data() will overwrite it to 0), as
done elsewhere in this function.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/dummy_hcd.c

index 22236ecb2e29fa2fee6433e93c56356568826c6c..c588e8e486e590843ed2714403f282a7b3748a68 100644 (file)
@@ -2660,8 +2660,10 @@ static int __init init(void)
        }
        for (i = 0; i < mod_data.num; i++) {
                dum[i] = kzalloc(sizeof(struct dummy), GFP_KERNEL);
-               if (!dum[i])
+               if (!dum[i]) {
+                       retval = -ENOMEM;
                        goto err_add_pdata;
+               }
                retval = platform_device_add_data(the_hcd_pdev[i], &dum[i],
                                sizeof(void *));
                if (retval)