SUNRPC: IS_ERR/PTR_ERR confusion
authorRoel Kluin <roel.kluin@gmail.com>
Tue, 8 Dec 2009 18:13:03 +0000 (13:13 -0500)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 8 Dec 2009 18:13:03 +0000 (13:13 -0500)
IS_ERR returns 1 or 0, PTR_ERR returns the error value.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/auth_gss/auth_gss.c

index fc6a43ccd95091154cb7aeff1aa457102efe5e93..129d75ea25d24fbbe5f066dc8a33ceaa4c0dbbbb 100644 (file)
@@ -485,7 +485,7 @@ gss_refresh_upcall(struct rpc_task *task)
        dprintk("RPC: %5u gss_refresh_upcall for uid %u\n", task->tk_pid,
                                                                cred->cr_uid);
        gss_msg = gss_setup_upcall(task->tk_client, gss_auth, cred);
-       if (IS_ERR(gss_msg) == -EAGAIN) {
+       if (PTR_ERR(gss_msg) == -EAGAIN) {
                /* XXX: warning on the first, under the assumption we
                 * shouldn't normally hit this case on a refresh. */
                warn_gssd();