clockevents/drivers/pxa: Migrate to new 'set-state' interface
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 18 Jun 2015 10:54:30 +0000 (16:24 +0530)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 10 Aug 2015 09:40:35 +0000 (11:40 +0200)
Migrate pxa driver to the new 'set-state' interface provided by
clockevents core, the earlier 'set-mode' interface is marked obsolete
now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

Both oneshot and shutdown modes had exactly same code and so only a
single callback is sufficient now, which will be called for both the
modes.

Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
drivers/clocksource/pxa_timer.c

index d9438af2bbd6b7d001bbdf524b7281a7a0c0816e..45b6a49997137beb7f67877a682a19c2066fffe6 100644 (file)
@@ -88,26 +88,12 @@ pxa_osmr0_set_next_event(unsigned long delta, struct clock_event_device *dev)
        return (signed)(next - oscr) <= MIN_OSCR_DELTA ? -ETIME : 0;
 }
 
-static void
-pxa_osmr0_set_mode(enum clock_event_mode mode, struct clock_event_device *dev)
+static int pxa_osmr0_shutdown(struct clock_event_device *evt)
 {
-       switch (mode) {
-       case CLOCK_EVT_MODE_ONESHOT:
-               timer_writel(timer_readl(OIER) & ~OIER_E0, OIER);
-               timer_writel(OSSR_M0, OSSR);
-               break;
-
-       case CLOCK_EVT_MODE_UNUSED:
-       case CLOCK_EVT_MODE_SHUTDOWN:
-               /* initializing, released, or preparing for suspend */
-               timer_writel(timer_readl(OIER) & ~OIER_E0, OIER);
-               timer_writel(OSSR_M0, OSSR);
-               break;
-
-       case CLOCK_EVT_MODE_RESUME:
-       case CLOCK_EVT_MODE_PERIODIC:
-               break;
-       }
+       /* initializing, released, or preparing for suspend */
+       timer_writel(timer_readl(OIER) & ~OIER_E0, OIER);
+       timer_writel(OSSR_M0, OSSR);
+       return 0;
 }
 
 #ifdef CONFIG_PM
@@ -147,13 +133,14 @@ static void pxa_timer_resume(struct clock_event_device *cedev)
 #endif
 
 static struct clock_event_device ckevt_pxa_osmr0 = {
-       .name           = "osmr0",
-       .features       = CLOCK_EVT_FEAT_ONESHOT,
-       .rating         = 200,
-       .set_next_event = pxa_osmr0_set_next_event,
-       .set_mode       = pxa_osmr0_set_mode,
-       .suspend        = pxa_timer_suspend,
-       .resume         = pxa_timer_resume,
+       .name                   = "osmr0",
+       .features               = CLOCK_EVT_FEAT_ONESHOT,
+       .rating                 = 200,
+       .set_next_event         = pxa_osmr0_set_next_event,
+       .set_state_shutdown     = pxa_osmr0_shutdown,
+       .set_state_oneshot      = pxa_osmr0_shutdown,
+       .suspend                = pxa_timer_suspend,
+       .resume                 = pxa_timer_resume,
 };
 
 static struct irqaction pxa_ost0_irq = {