mlxsw: spectrum: Remove redundant function argument
authorIdo Schimmel <idosch@mellanox.com>
Mon, 20 Jun 2016 21:04:08 +0000 (23:04 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jun 2016 09:02:49 +0000 (05:02 -0400)
In all call sites 'only_uc' is set to false, so strip it.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c
drivers/net/ethernet/mellanox/mlxsw/spectrum.h
drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c

index b9998025f66a37c4d41fcfd656aa78a43efc7d73..90cf6c519b111332e15e58313f8fa95e6819c287 100644 (file)
@@ -791,7 +791,7 @@ int mlxsw_sp_port_add_vid(struct net_device *dev, __be16 __always_unused proto,
 
        if (!vfid->nr_vports) {
                err = mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid,
-                                              true, false);
+                                              true);
                if (err) {
                        netdev_err(dev, "Failed to setup flooding for vFID=%d\n",
                                   vfid->vfid);
@@ -859,8 +859,7 @@ err_port_vid_to_fid_set:
                mlxsw_sp_port_vlan_mode_trans(mlxsw_sp_port);
 err_port_vp_mode_trans:
        if (!vfid->nr_vports)
-               mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, false,
-                                        false);
+               mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, false);
 err_vport_flood_set:
        mlxsw_sp_port_vport_destroy(mlxsw_sp_vport);
 err_port_vport_create:
@@ -3267,8 +3266,7 @@ static void mlxsw_sp_vport_bridge_leave(struct mlxsw_sp_port *mlxsw_sp_vport,
                goto err_port_vid_learning_set;
        }
 
-       err = mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, false,
-                                      false);
+       err = mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, false);
        if (err) {
                netdev_err(dev, "Failed clear to clear flooding\n");
                goto err_vport_flood_set;
@@ -3327,7 +3325,7 @@ static int mlxsw_sp_vport_bridge_join(struct mlxsw_sp_port *mlxsw_sp_vport,
                }
        }
 
-       err = mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, true, false);
+       err = mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, true);
        if (err) {
                netdev_err(dev, "Failed to setup flooding for vFID=%d\n",
                           vfid->vfid);
@@ -3386,7 +3384,7 @@ err_port_vid_to_fid_validate:
 err_port_vid_to_fid_invalidate:
        mlxsw_sp_port_vid_learning_set(mlxsw_sp_vport, vid, false);
 err_port_vid_learning_set:
-       mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, false, false);
+       mlxsw_sp_vport_flood_set(mlxsw_sp_vport, vfid->vfid, false);
 err_port_flood_set:
        if (!vfid->nr_vports)
                mlxsw_sp_br_vfid_destroy(mlxsw_sp, vfid);
index 5da98b4c78eb1630d52244fa18d3df8a4894f217..58a2a5decffad93ea70fa272bc1f6d4d2e86a4a0 100644 (file)
@@ -367,7 +367,7 @@ int mlxsw_sp_port_add_vid(struct net_device *dev, __be16 __always_unused proto,
 int mlxsw_sp_port_kill_vid(struct net_device *dev,
                           __be16 __always_unused proto, u16 vid);
 int mlxsw_sp_vport_flood_set(struct mlxsw_sp_port *mlxsw_sp_vport, u16 vfid,
-                            bool set, bool only_uc);
+                            bool set);
 void mlxsw_sp_port_active_vlans_del(struct mlxsw_sp_port *mlxsw_sp_port);
 int mlxsw_sp_port_pvid_set(struct mlxsw_sp_port *mlxsw_sp_port, u16 vid);
 int mlxsw_sp_port_ets_set(struct mlxsw_sp_port *mlxsw_sp_port,
index 3710f19ed6bbbaa119415538c7951183fe972694..02c126cc241909e18c8f66684f18740c5268b48f 100644 (file)
@@ -261,13 +261,13 @@ err_port_flood_set:
 }
 
 int mlxsw_sp_vport_flood_set(struct mlxsw_sp_port *mlxsw_sp_vport, u16 vfid,
-                            bool set, bool only_uc)
+                            bool set)
 {
        /* In case of vFIDs, index into the flooding table is relative to
         * the start of the vFIDs range.
         */
        return __mlxsw_sp_port_flood_set(mlxsw_sp_vport, vfid, vfid, set,
-                                        only_uc);
+                                        false);
 }
 
 static int mlxsw_sp_port_attr_br_flags_set(struct mlxsw_sp_port *mlxsw_sp_port,