[PATCH] USB: fix hid core to return proper error code from probe
authorStelian Pop <stelian@popies.net>
Wed, 22 Jun 2005 15:53:28 +0000 (17:53 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 23 Jun 2005 06:01:09 +0000 (23:01 -0700)
Drivers need to return -ENODEV when they can't bind to a device.
Anything else stops the "bind a device to a driver" search.

From: Stelian Pop <stelian@popies.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/input/hid-core.c

index 2d8bd9dcc6edae2b8d1c4ea112f0c5e66cddc149..740dec1f521dde53d3ae480d0f61418b7f1d1eef 100644 (file)
@@ -1762,7 +1762,7 @@ static int hid_probe(struct usb_interface *intf, const struct usb_device_id *id)
                        intf->altsetting->desc.bInterfaceNumber);
 
        if (!(hid = usb_hid_configure(intf)))
-               return -EIO;
+               return -ENODEV;
 
        hid_init_reports(hid);
        hid_dump_device(hid);
@@ -1777,7 +1777,7 @@ static int hid_probe(struct usb_interface *intf, const struct usb_device_id *id)
        if (!hid->claimed) {
                printk ("HID device not claimed by input or hiddev\n");
                hid_disconnect(intf);
-               return -EIO;
+               return -ENODEV;
        }
 
        printk(KERN_INFO);