scsi: cxlflash: Remove zeroing of private command data

The SCSI core now zeroes the per-command private data area prior to
calling into the LLD. Replace the clearing operation that takes place
when the private command data reference is obtained with a routine that
performs common initializations. The zeroing that takes place in the
device reset path remains intact as the private command data associated
with the specified SCSI command is not guaranteed to be cleared.

Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/cxlflash/common.h b/drivers/scsi/cxlflash/common.h
index e95e5a516b5eb3d92a504c88f02ea0d907b0968c..6d95e8e147e0823741be9b9cc68ed1f4188b4a5c 100644 (file)
--- a/drivers/scsi/cxlflash/common.h
+++ b/drivers/scsi/cxlflash/common.h
@@ -178,15 +178,22 @@ static inline struct afu_cmd *sc_to_afuc(struct scsi_cmnd *sc)
        return PTR_ALIGN(scsi_cmd_priv(sc), __alignof__(struct afu_cmd));
 }
 
-static inline struct afu_cmd *sc_to_afucz(struct scsi_cmnd *sc)
+static inline struct afu_cmd *sc_to_afuci(struct scsi_cmnd *sc)
 {
        struct afu_cmd *afuc = sc_to_afuc(sc);
 
-       memset(afuc, 0, sizeof(*afuc));
        INIT_LIST_HEAD(&afuc->queue);
        return afuc;
 }
 
+static inline struct afu_cmd *sc_to_afucz(struct scsi_cmnd *sc)
+{
+       struct afu_cmd *afuc = sc_to_afuc(sc);
+
+       memset(afuc, 0, sizeof(*afuc));
+       return sc_to_afuci(sc);
+}
+
 struct hwq {
        /* Stuff requiring alignment go first. */
        struct sisl_ioarcb sq[NUM_SQ_ENTRY];            /* 16K SQ */

diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index 0cce442c260adc7690217f95f33b3dbf42d816d0..43389825299abc88a8d9323f858bcfb9f0640889 100644 (file)
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -543,7 +543,7 @@ static int cxlflash_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scp)
        struct cxlflash_cfg *cfg = shost_priv(host);
        struct afu *afu = cfg->afu;
        struct device *dev = &cfg->dev->dev;
-       struct afu_cmd *cmd = sc_to_afucz(scp);
+       struct afu_cmd *cmd = sc_to_afuci(scp);
        struct scatterlist *sg = scsi_sglist(scp);
        int hwq_index = cmd_to_target_hwq(host, scp, afu);
        struct hwq *hwq = get_hwq(afu, hwq_index);