mmc: sdio: Keep card runtime resumed while adding function devices

Drivers core will runtime suspend a device with no driver. That means the
SDIO card will be runtime suspended as soon as it is added. It is then
runtime resumed to add each function. That is entirely pointless, so add
pm runtime get/put to keep the SDIO card runtime resumed until the function
devices have been added.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index f077fc8219d0f6b8eb10fed7fa62649e80c23025..cc43687ca241918fe40d8511eab5fe6ecb848d52 100644 (file)
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -1103,6 +1103,12 @@ int mmc_attach_sdio(struct mmc_host *host)
         * Enable runtime PM only if supported by host+card+board
         */
        if (host->caps & MMC_CAP_POWER_OFF_CARD) {
+               /*
+                * Do not allow runtime suspend until after SDIO function
+                * devices are added.
+                */
+               pm_runtime_get_noresume(&card->dev);
+
                /*
                 * Let runtime PM core know our card is active
                 */
@@ -1155,6 +1161,9 @@ int mmc_attach_sdio(struct mmc_host *host)
                        goto remove_added;
        }
 
+       if (host->caps & MMC_CAP_POWER_OFF_CARD)
+               pm_runtime_put(&card->dev);
+
        mmc_claim_host(host);
        return 0;
 
@@ -1164,7 +1173,9 @@ remove:
 remove_added:
        /*
         * The devices are being deleted so it is not necessary to disable
-        * runtime PM.
+        * runtime PM. Similarly we also don't pm_runtime_put() the SDIO card
+        * because it needs to be active to remove any function devices that
+        * were probed, and after that it gets deleted.
         */
        mmc_sdio_remove(host);
        mmc_claim_host(host);