rtl8187: Remove pointless check in rtl8187_rx_cb().
authorDavid S. Miller <davem@davemloft.net>
Thu, 28 May 2009 08:22:57 +0000 (01:22 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 May 2009 08:22:57 +0000 (01:22 -0700)
First of all, it exposes the SKB list implementation.

Second of all it's not needed.  If we get called here, we
successfully enqueued the URB with the linked SKB and
such a completion only gets called one time on such an
SKB.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wireless/rtl818x/rtl8187_dev.c

index 6499ccc34c942619fc65f8ea50440c43bfb291bf..3f22cc0c96790a59e48c729a93ab4eed89c35115 100644 (file)
@@ -321,12 +321,7 @@ static void rtl8187_rx_cb(struct urb *urb)
        unsigned long f;
 
        spin_lock_irqsave(&priv->rx_queue.lock, f);
-       if (skb->next)
-               __skb_unlink(skb, &priv->rx_queue);
-       else {
-               spin_unlock_irqrestore(&priv->rx_queue.lock, f);
-               return;
-       }
+       __skb_unlink(skb, &priv->rx_queue);
        spin_unlock_irqrestore(&priv->rx_queue.lock, f);
        skb_put(skb, urb->actual_length);