ALSA: sh: constify snd_pcm_ops structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 18 Aug 2017 07:45:18 +0000 (13:15 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sat, 19 Aug 2017 09:02:23 +0000 (11:02 +0200)
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/sh/aica.c
sound/sh/sh_dac_audio.c

index 822608da2e210fc11e44eccedd90b54a39cf74a0..fdc680ae8aa09c037ac01cc6623e6f6d15797993 100644 (file)
@@ -436,7 +436,7 @@ static unsigned long snd_aicapcm_pcm_pointer(struct snd_pcm_substream
        return readl(AICA_CONTROL_CHANNEL_SAMPLE_NUMBER);
 }
 
-static struct snd_pcm_ops snd_aicapcm_playback_ops = {
+static const struct snd_pcm_ops snd_aicapcm_playback_ops = {
        .open = snd_aicapcm_pcm_open,
        .close = snd_aicapcm_pcm_close,
        .ioctl = snd_pcm_lib_ioctl,
index a077f1c386cee169bc014b93a2fdfee431605d32..e71e6a7188026207857e9270e82518c49ac44406 100644 (file)
@@ -252,7 +252,7 @@ snd_pcm_uframes_t snd_sh_dac_pcm_pointer(struct snd_pcm_substream *substream)
 }
 
 /* pcm ops */
-static struct snd_pcm_ops snd_sh_dac_pcm_ops = {
+static const struct snd_pcm_ops snd_sh_dac_pcm_ops = {
        .open           = snd_sh_dac_pcm_open,
        .close          = snd_sh_dac_pcm_close,
        .ioctl          = snd_pcm_lib_ioctl,