atm: horizon: Use setup_timer
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Thu, 30 Jun 2016 08:44:01 +0000 (14:14 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Jul 2016 09:58:26 +0000 (05:58 -0400)
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

The Coccinelle semantic patch that fixes this problem is
as follows:
@@
expression t,d,f,e1;
identifier x1;
statement S1;
@@

(
-t.data = d;
|
-t.function = f;
|
-init_timer(&t);
+setup_timer(&t,f,d);
|
-init_timer_on_stack(&t);
+setup_timer_on_stack(&t,f,d);
)
<... when != S1
t.x1 = e1;
...>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/horizon.c

index 527bbd595e3796debc2c0e2d60ea0a8e3f504df3..5fc81e240c242a12fe972b7054c5d5162cdd4881 100644 (file)
@@ -2795,9 +2795,7 @@ static int hrz_probe(struct pci_dev *pci_dev,
        dev->atm_dev->ci_range.vpi_bits = vpi_bits;
        dev->atm_dev->ci_range.vci_bits = 10-vpi_bits;
 
-       init_timer(&dev->housekeeping);
-       dev->housekeeping.function = do_housekeeping;
-       dev->housekeeping.data = (unsigned long) dev;
+       setup_timer(&dev->housekeeping, do_housekeeping, (unsigned long) dev);
        mod_timer(&dev->housekeeping, jiffies);
 
 out: