mac80211: lazily stop queues in add_pending
authorJohannes Berg <johannes.berg@intel.com>
Wed, 28 Mar 2012 09:04:28 +0000 (11:04 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 10 Apr 2012 18:54:11 +0000 (14:54 -0400)
When adding pending SKBs there's no need to
stop all queues, we only need to stop those
that we're adding frames to. Implement that
by lazily stopping a queue as we add an SKB.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/util.c

index ef725cabb09950d5163156a6d93f18803e89bb90..471a831066dd76271e0db4fa60b5ce1c2f612612 100644 (file)
@@ -385,10 +385,6 @@ void ieee80211_add_pending_skbs_fn(struct ieee80211_local *local,
        int queue, i;
 
        spin_lock_irqsave(&local->queue_stop_reason_lock, flags);
-       for (i = 0; i < hw->queues; i++)
-               __ieee80211_stop_queue(hw, i,
-                       IEEE80211_QUEUE_STOP_REASON_SKB_ADD);
-
        while ((skb = skb_dequeue(skbs))) {
                struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
 
@@ -398,6 +394,10 @@ void ieee80211_add_pending_skbs_fn(struct ieee80211_local *local,
                }
 
                queue = skb_get_queue_mapping(skb);
+
+               __ieee80211_stop_queue(hw, queue,
+                               IEEE80211_QUEUE_STOP_REASON_SKB_ADD);
+
                __skb_queue_tail(&local->pending[queue], skb);
        }