drm/i915: precendence bug in GT_PARITY_ERROR()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 24 Sep 2013 07:57:35 +0000 (10:57 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 1 Oct 2013 05:45:13 +0000 (07:45 +0200)
The | operation has higher precedence than "?:" so the macro always
returns GT_RENDER_L3_PARITY_ERROR_INTERRUPT_S1.

This regression has been introduce in "drm/i915: Add second slice l3
remapping".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_reg.h

index f7ad97572c4d25ad7e34e7cd516d8f9d11d36d2a..00fda45728d749c91992c7546e982efd8edba79a 100644 (file)
 
 #define GT_PARITY_ERROR(dev) \
        (GT_RENDER_L3_PARITY_ERROR_INTERRUPT | \
-        IS_HASWELL(dev) ? GT_RENDER_L3_PARITY_ERROR_INTERRUPT_S1 : 0)
+        (IS_HASWELL(dev) ? GT_RENDER_L3_PARITY_ERROR_INTERRUPT_S1 : 0))
 
 /* These are all the "old" interrupts */
 #define ILK_BSD_USER_INTERRUPT                         (1<<5)