ide: hpt366: fix incorrect mask when checking at cmd_high_time
authorColin Ian King <colin.king@canonical.com>
Tue, 12 Jul 2016 10:59:39 +0000 (11:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Jul 2016 22:25:31 +0000 (15:25 -0700)
According to the HPT366 data sheet, PCI config space dword 0x40-0x43
bits 11:8 specify the primary drive cmd_high_time, however,
currently just 3 bits of the 4 are being used because the mask
is 0x07 and not 0x0f.  Fix the mask, allowing for the 40MHz clock
to be detected.

Also add in missing space between switch and parenthesis to clean
up a checkpatch warning.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/hpt366.c

index f94baadbf42474ed67f71b02635c48d1496b7f2a..0ceae5cbd89a327d198a5bac595f2e40882eefab 100644 (file)
@@ -1012,7 +1012,7 @@ static int init_chipset_hpt366(struct pci_dev *dev)
                pci_read_config_dword(dev, 0x40, &itr1);
 
                /* Detect PCI clock by looking at cmd_high_time. */
-               switch((itr1 >> 8) & 0x07) {
+               switch ((itr1 >> 8) & 0x0f) {
                        case 0x09:
                                pci_clk = 40;
                                break;