powerpc/PCI: Add struct pci_ops member names to initialization
authorRob Herring <robh@kernel.org>
Sat, 10 Jan 2015 02:34:38 +0000 (20:34 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 22 Jan 2015 19:58:43 +0000 (13:58 -0600)
Some instances of pci_ops initialization rely on the read/write members'
location in the struct.  This is fragile and may break when adding new
members to the beginning of the struct.

No functional change.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Michael Ellerman <mpe@ellerman.id.au>
CC: linuxppc-dev@lists.ozlabs.org
CC: cbe-oss-dev@lists.ozlabs.org
arch/powerpc/platforms/cell/celleb_scc_pciex.c

index f223875980405ef6547f6dd30b6645990c27e120..94170e4f2ce775d19c4255eddb339512bff13350 100644 (file)
@@ -399,8 +399,8 @@ static int scc_pciex_write_config(struct pci_bus *bus, unsigned int devfn,
 }
 
 static struct pci_ops scc_pciex_pci_ops = {
-       scc_pciex_read_config,
-       scc_pciex_write_config,
+       .read = scc_pciex_read_config,
+       .write = scc_pciex_write_config,
 };
 
 static void pciex_clear_intr_all(unsigned int __iomem *base)