KVM: SVM: Fix TSC MSR read in nested SVM
authorNadav Har'El <nyh@il.ibm.com>
Tue, 2 Aug 2011 12:55:23 +0000 (15:55 +0300)
committerAvi Kivity <avi@redhat.com>
Sun, 25 Sep 2011 16:18:03 +0000 (19:18 +0300)
When the TSC MSR is read by an L2 guest (when L1 allowed this MSR to be
read without exit), we need to return L2's notion of the TSC, not L1's.

The current code incorrectly returned L1 TSC, because svm_get_msr() was also
used in x86.c where this was assumed, but now that these places call the new
svm_read_l1_tsc(), the MSR read can be fixed.

Signed-off-by: Nadav Har'El <nyh@il.ibm.com>
Tested-by: Joerg Roedel <joerg.roedel@amd.com>
Acked-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/svm.c

index 590d1d2d620b412891064e71ab07ab1d7ae508e0..8277f32017ad5b3fcab6ba1c2241454fa639bb4f 100644 (file)
@@ -2923,9 +2923,7 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data)
 
        switch (ecx) {
        case MSR_IA32_TSC: {
-               struct vmcb *vmcb = get_host_vmcb(svm);
-
-               *data = vmcb->control.tsc_offset +
+               *data = svm->vmcb->control.tsc_offset +
                        svm_scale_tsc(vcpu, native_read_tsc());
 
                break;