staging: unisys: visorbus: remove POSTCODE in create_bus_instance
authorDavid Kershner <david.kershner@unisys.com>
Tue, 18 Apr 2017 20:55:11 +0000 (16:55 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Apr 2017 09:49:52 +0000 (11:49 +0200)
Remove postcodes from create_bus_instance. If there is an error log
it with dev_err.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorbus_main.c

index 31f5d0d56f34da602dde624d77d995afe96f05a0..269f525fb8b9054d9d1b9c8d0e9722d165ede896 100644 (file)
@@ -995,8 +995,6 @@ create_bus_instance(struct visor_device *dev)
        int err;
        struct spar_vbus_headerinfo *hdr_info;
 
-       POSTCODE_LINUX(BUS_CREATE_ENTRY_PC, 0, 0, DIAG_SEVERITY_PRINT);
-
        hdr_info = kzalloc(sizeof(*hdr_info), GFP_KERNEL);
        if (!hdr_info)
                return -ENOMEM;
@@ -1019,11 +1017,8 @@ create_bus_instance(struct visor_device *dev)
                goto err_debugfs_dir;
 
        err = device_register(&dev->device);
-       if (err < 0) {
-               POSTCODE_LINUX(DEVICE_CREATE_FAILURE_PC, 0, id,
-                              DIAG_SEVERITY_ERR);
+       if (err < 0)
                goto err_debugfs_dir;
-       }
 
        list_add_tail(&dev->list_all, &list_all_bus_instances);
 
@@ -1038,6 +1033,7 @@ create_bus_instance(struct visor_device *dev)
 err_debugfs_dir:
        debugfs_remove_recursive(dev->debugfs_dir);
        kfree(hdr_info);
+       dev_err(&dev->device, "create_bus_instance failed: %d\n", err);
        return err;
 }