mfd: ab8500: world-writable debugfs register-* files
authorVasiliy Kulikov <segoon@openwall.com>
Fri, 4 Feb 2011 12:23:43 +0000 (15:23 +0300)
committerSamuel Ortiz <sameo@linux.intel.com>
Wed, 23 Mar 2011 09:41:48 +0000 (10:41 +0100)
Don't allow everybody to interact with hardware registers.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/ab8500-debugfs.c

index 3c1541ae722321f43b27a01294e553a6d4bcdf58..64748e42ac039c101431782547194834cd4ca69b 100644 (file)
@@ -585,18 +585,18 @@ static int __devinit ab8500_debug_probe(struct platform_device *plf)
                goto exit_destroy_dir;
 
        ab8500_bank_file = debugfs_create_file("register-bank",
-               (S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev, &ab8500_bank_fops);
+               (S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev, &ab8500_bank_fops);
        if (!ab8500_bank_file)
                goto exit_destroy_reg;
 
        ab8500_address_file = debugfs_create_file("register-address",
-               (S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev,
+               (S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev,
                &ab8500_address_fops);
        if (!ab8500_address_file)
                goto exit_destroy_bank;
 
        ab8500_val_file = debugfs_create_file("register-value",
-               (S_IRUGO | S_IWUGO), ab8500_dir, &plf->dev, &ab8500_val_fops);
+               (S_IRUGO | S_IWUSR), ab8500_dir, &plf->dev, &ab8500_val_fops);
        if (!ab8500_val_file)
                goto exit_destroy_address;