iommu/arm-smmu: Delete an unnecessary check before free_io_pgtable_ops()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 6 Nov 2015 17:32:41 +0000 (18:32 +0100)
committerWill Deacon <will.deacon@arm.com>
Thu, 17 Dec 2015 12:05:32 +0000 (12:05 +0000)
The free_io_pgtable_ops() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Will Deacon <will.deacon@arm.com>
drivers/iommu/arm-smmu.c

index 47dc7a793f5cf070c50a2f2f98c15058582bb9ee..1ce4b85d5216dd8f8381e09a75fafd19af7acb94 100644 (file)
@@ -945,9 +945,7 @@ static void arm_smmu_destroy_domain_context(struct iommu_domain *domain)
                free_irq(irq, domain);
        }
 
-       if (smmu_domain->pgtbl_ops)
-               free_io_pgtable_ops(smmu_domain->pgtbl_ops);
-
+       free_io_pgtable_ops(smmu_domain->pgtbl_ops);
        __arm_smmu_free_bitmap(smmu->context_map, cfg->cbndx);
 }