EDAC, fsl_ddr: Fix error return code in fsl_mc_err_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 8 Sep 2016 15:58:04 +0000 (15:58 +0000)
committerBorislav Petkov <bp@suse.de>
Fri, 9 Sep 2016 17:27:22 +0000 (19:27 +0200)
Return negative error code from the edac_mc_add_mc() error handling case
instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: York Sun <york.sun@nxp.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1473350284-26482-1-git-send-email-weiyj.lk@gmail.com
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/fsl_ddr_edac.c

index 4ddf8382369f1d657045c6187a81afd00187162e..9774f52f0c3ee63180e33d7543c2394829ed6906 100644 (file)
@@ -564,7 +564,8 @@ int fsl_mc_err_probe(struct platform_device *op)
        /* clear all error bits */
        ddr_out32(pdata->mc_vbase + FSL_MC_ERR_DETECT, ~0);
 
-       if (edac_mc_add_mc_with_groups(mci, fsl_ddr_dev_groups)) {
+       res = edac_mc_add_mc_with_groups(mci, fsl_ddr_dev_groups);
+       if (res) {
                edac_dbg(3, "failed edac_mc_add_mc()\n");
                goto err;
        }