tracing/stat: remove unappropriate safe walk on list
authorFrederic Weisbecker <fweisbec@gmail.com>
Sat, 30 May 2009 02:25:30 +0000 (04:25 +0200)
committerFrederic Weisbecker <fweisbec@gmail.com>
Mon, 1 Jun 2009 23:18:33 +0000 (01:18 +0200)
register_stat_tracer() uses list_for_each_entry_safe
to check whether a tracer is already present in the list.
But we don't delete anything from the list here, so
we don't need the safe version

[ Impact: cleanup list use is stat tracing ]

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
kernel/trace/trace_stat.c

index 17f20ebdad2a53a5ef66ea01f1f0b7e348c2ee0d..c00643733f4ccca7be15b22ef311ec03711edc48 100644 (file)
@@ -316,7 +316,7 @@ static int init_stat_file(struct stat_session *session)
 
 int register_stat_tracer(struct tracer_stat *trace)
 {
-       struct stat_session *session, *node, *tmp;
+       struct stat_session *session, *node;
        int ret;
 
        if (!trace)
@@ -327,7 +327,7 @@ int register_stat_tracer(struct tracer_stat *trace)
 
        /* Already registered? */
        mutex_lock(&all_stat_sessions_mutex);
-       list_for_each_entry_safe(node, tmp, &all_stat_sessions, session_list) {
+       list_for_each_entry(node, &all_stat_sessions, session_list) {
                if (node->ts == trace) {
                        mutex_unlock(&all_stat_sessions_mutex);
                        return -EINVAL;