ALSA: jack: Fix another NULL dereference due to empty input jack
authorTakashi Iwai <tiwai@suse.de>
Thu, 30 Apr 2015 13:25:00 +0000 (15:25 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 30 Apr 2015 13:27:55 +0000 (15:27 +0200)
Another fixes for NULL jack->input_dev in some places in jack.c.

Fixes: 2ba2dfa1fcc7 ('ALSA: hda - Update to use the new jack kctls method')
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/jack.c

index 0dbd618e3c942bf264d8f44d681fc4d1adc312d5..eb66327b5f1c7311276596a8985e324cbef27cf6 100644 (file)
@@ -87,6 +87,10 @@ static int snd_jack_dev_register(struct snd_device *device)
 
        snprintf(jack->name, sizeof(jack->name), "%s %s",
                 card->shortname, jack->id);
+
+       if (!jack->input_dev)
+               return 0;
+
        jack->input_dev->name = jack->name;
 
        /* Default to the sound card device. */
@@ -278,6 +282,8 @@ EXPORT_SYMBOL(snd_jack_new);
 void snd_jack_set_parent(struct snd_jack *jack, struct device *parent)
 {
        WARN_ON(jack->registered);
+       if (!jack->input_dev)
+               return;
 
        jack->input_dev->dev.parent = parent;
 }