[media] exynos4-is: Correct input DMA YUV order configuration

This patch fixes erroneous setup of the YUV order caused by not
clearing FIMC_REG_MSCTRL_ORDER422_MASK bit field before setting
proper FIMC_REG_MSCTRL_ORDER422 bits. This resulted in false
colors for YUYV, YVYU, UYVY, VYUY color formats, depending in
what sequence those were configured by user space.
YUV order definitions are corrected so that following convention
is used:
        | byte3 | byte2 | byte1 | byte0
 -------+-------+-------+-------+------
 YCBYCR | CR    | Y     | CB    | Y
 YCRYCB | CB    | Y     | CR    | Y
 CBYCRY | Y     | CR    | Y     | CB
 CRYCBY | Y     | CB    | Y     | CR

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c
index 90d907e1a5f8ac7571e3a7e2a18e774f64f53710..f25807d7bc8add6630661f38f3d293206b234ea2 100644 (file)
--- a/drivers/media/platform/exynos4-is/fimc-core.c
+++ b/drivers/media/platform/exynos4-is/fimc-core.c
@@ -412,34 +412,34 @@ void fimc_set_yuv_order(struct fimc_ctx *ctx)
        /* Set order for 1 plane input formats. */
        switch (ctx->s_frame.fmt->color) {
        case FIMC_FMT_YCRYCB422:
-               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_CBYCRY;
+               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_YCRYCB;
                break;
        case FIMC_FMT_CBYCRY422:
-               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_YCRYCB;
+               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_CBYCRY;
                break;
        case FIMC_FMT_CRYCBY422:
-               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_YCBYCR;
+               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_CRYCBY;
                break;
        case FIMC_FMT_YCBYCR422:
        default:
-               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_CRYCBY;
+               ctx->in_order_1p = FIMC_REG_MSCTRL_ORDER422_YCBYCR;
                break;
        }
        dbg("ctx->in_order_1p= %d", ctx->in_order_1p);
 
        switch (ctx->d_frame.fmt->color) {
        case FIMC_FMT_YCRYCB422:
-               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_CBYCRY;
+               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_YCRYCB;
                break;
        case FIMC_FMT_CBYCRY422:
-               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_YCRYCB;
+               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_CBYCRY;
                break;
        case FIMC_FMT_CRYCBY422:
-               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_YCBYCR;
+               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_CRYCBY;
                break;
        case FIMC_FMT_YCBYCR422:
        default:
-               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_CRYCBY;
+               ctx->out_order_1p = FIMC_REG_CIOCTRL_ORDER422_YCBYCR;
                break;
        }
        dbg("ctx->out_order_1p= %d", ctx->out_order_1p);

diff --git a/drivers/media/platform/exynos4-is/fimc-reg.c b/drivers/media/platform/exynos4-is/fimc-reg.c
index c82e9bdaae94dcf4a3c3292a73bca447225fe66e..f079f36099de76909d6967061c9266a91e728716 100644 (file)
--- a/drivers/media/platform/exynos4-is/fimc-reg.c
+++ b/drivers/media/platform/exynos4-is/fimc-reg.c
@@ -449,7 +449,8 @@ void fimc_hw_set_in_dma(struct fimc_ctx *ctx)
                 | FIMC_REG_MSCTRL_IN_BURST_COUNT_MASK
                 | FIMC_REG_MSCTRL_INPUT_MASK
                 | FIMC_REG_MSCTRL_C_INT_IN_MASK
-                | FIMC_REG_MSCTRL_2P_IN_ORDER_MASK);
+                | FIMC_REG_MSCTRL_2P_IN_ORDER_MASK
+                | FIMC_REG_MSCTRL_ORDER422_MASK);
 
        cfg |= (FIMC_REG_MSCTRL_IN_BURST_COUNT(4)
                | FIMC_REG_MSCTRL_INPUT_MEMORY

diff --git a/drivers/media/platform/exynos4-is/fimc-reg.h b/drivers/media/platform/exynos4-is/fimc-reg.h
index 01da7f3622bf37630da3ff2777fdefcaea647469..6c97798c75a5370e4215073544056d39715a5f49 100644 (file)
--- a/drivers/media/platform/exynos4-is/fimc-reg.h
+++ b/drivers/media/platform/exynos4-is/fimc-reg.h
@@ -95,10 +95,10 @@
 /* Output DMA control */
 #define FIMC_REG_CIOCTRL                       0x4c
 #define FIMC_REG_CIOCTRL_ORDER422_MASK         (3 << 0)
-#define FIMC_REG_CIOCTRL_ORDER422_CRYCBY       (0 << 0)
-#define FIMC_REG_CIOCTRL_ORDER422_CBYCRY       (1 << 0)
-#define FIMC_REG_CIOCTRL_ORDER422_YCRYCB       (2 << 0)
-#define FIMC_REG_CIOCTRL_ORDER422_YCBYCR       (3 << 0)
+#define FIMC_REG_CIOCTRL_ORDER422_YCBYCR       (0 << 0)
+#define FIMC_REG_CIOCTRL_ORDER422_YCRYCB       (1 << 0)
+#define FIMC_REG_CIOCTRL_ORDER422_CBYCRY       (2 << 0)
+#define FIMC_REG_CIOCTRL_ORDER422_CRYCBY       (3 << 0)
 #define FIMC_REG_CIOCTRL_LASTIRQ_ENABLE                (1 << 2)
 #define FIMC_REG_CIOCTRL_YCBCR_3PLANE          (0 << 3)
 #define FIMC_REG_CIOCTRL_YCBCR_2PLANE          (1 << 3)
@@ -220,10 +220,10 @@
 #define FIMC_REG_MSCTRL_FLIP_180               (3 << 13)
 #define FIMC_REG_MSCTRL_FIFO_CTRL_FULL         (1 << 12)
 #define FIMC_REG_MSCTRL_ORDER422_SHIFT         4
-#define FIMC_REG_MSCTRL_ORDER422_YCBYCR                (0 << 4)
-#define FIMC_REG_MSCTRL_ORDER422_CBYCRY                (1 << 4)
-#define FIMC_REG_MSCTRL_ORDER422_YCRYCB                (2 << 4)
-#define FIMC_REG_MSCTRL_ORDER422_CRYCBY                (3 << 4)
+#define FIMC_REG_MSCTRL_ORDER422_CRYCBY                (0 << 4)
+#define FIMC_REG_MSCTRL_ORDER422_YCRYCB                (1 << 4)
+#define FIMC_REG_MSCTRL_ORDER422_CBYCRY                (2 << 4)
+#define FIMC_REG_MSCTRL_ORDER422_YCBYCR                (3 << 4)
 #define FIMC_REG_MSCTRL_ORDER422_MASK          (3 << 4)
 #define FIMC_REG_MSCTRL_INPUT_EXTCAM           (0 << 3)
 #define FIMC_REG_MSCTRL_INPUT_MEMORY           (1 << 3)