ftrace: break out modify loop immediately on detection of error
authorSteven Rostedt <srostedt@redhat.com>
Thu, 19 Feb 2009 18:41:27 +0000 (13:41 -0500)
committerSteven Rostedt <srostedt@redhat.com>
Fri, 20 Feb 2009 19:30:20 +0000 (14:30 -0500)
Impact: added precaution on failure detection

Break out of the modifying loop as soon as a failure is detected.
This is just an added precaution found by code review and was not
found by any bug chasing.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
kernel/trace/ftrace.c

index 72316d9647bdf28ba68369ce2cf84cf2e26c0407..11ad796ca0495ee9ab0bb47a99f40e86bcfc1d43 100644 (file)
@@ -561,8 +561,11 @@ static void ftrace_replace_code(int enable)
                                if ((system_state == SYSTEM_BOOTING) ||
                                    !core_kernel_text(rec->ip)) {
                                        ftrace_free_rec(rec);
-                               } else
+                               } else {
                                        ftrace_bug(failed, rec->ip);
+                                       /* Stop processing */
+                                       return;
+                               }
                        }
                }
        }