[S390] dcssblk: prevent early access without own make_request function
authorChristian Borntraeger <borntraeger@de.ibm.com>
Tue, 4 Dec 2007 15:09:03 +0000 (16:09 +0100)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Tue, 4 Dec 2007 15:09:57 +0000 (16:09 +0100)
When loading a dcss segment with the dcssblk driver, sometimes the
following kind of message appears:

bio too big device dcssblk0 (8 > 0)
Buffer I/O error on device dcssblk0, logical block 172016
..

The fix is to move the disk registration after setting the
make_request function, to avoid calls into generic_make_request
for dcssblock without having the make_request function set up
properly.

Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/block/dcssblk.c

index 5e083d1f57e70a115dac935895d4e40bcd6a5624..15a5789b773425ba35a0ee0e6f43b8bf18866872 100644 (file)
@@ -472,11 +472,11 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char
        if (rc)
                goto unregister_dev;
 
-       add_disk(dev_info->gd);
-
        blk_queue_make_request(dev_info->dcssblk_queue, dcssblk_make_request);
        blk_queue_hardsect_size(dev_info->dcssblk_queue, 4096);
 
+       add_disk(dev_info->gd);
+
        switch (dev_info->segment_type) {
                case SEG_TYPE_SR:
                case SEG_TYPE_ER: