USB: ohci_usb warn "irq nobody cared" on shutdown
authorcaizhiyong <caizhiyong@huawei.com>
Fri, 26 Jul 2013 07:12:14 +0000 (07:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2013 20:55:21 +0000 (13:55 -0700)
When ohci-hcd is shutting down, call ohci_usb_reset reset ohci-hcd, the
root hub generate an interrupt, but ohci->rh_state is OHCI_RH_HALTED,
and ohci_irq ignore the interrupt, the kernel trigger warning "irq
nobody cared". ehci-hcd is first disable interrupts, then reset ehci.

This patch disable ohci interrupt before reset ohci.

The patch is tested at the arm cortex-a9 demo board.

Signed-off-by: caizhiyong <caizhiyong@huawei.com>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-hcd.c

index a9d3437da220393e9a9454f8a94914692a4d0354..8f6b695af6a470c5f5d5a5ca6a278e3a1186dfcc 100644 (file)
@@ -938,8 +938,8 @@ static void ohci_stop (struct usb_hcd *hcd)
        if (quirk_nec(ohci))
                flush_work(&ohci->nec_work);
 
-       ohci_usb_reset (ohci);
        ohci_writel (ohci, OHCI_INTR_MIE, &ohci->regs->intrdisable);
+       ohci_usb_reset(ohci);
        free_irq(hcd->irq, hcd);
        hcd->irq = 0;