xfrm: fix a read lock imbalance in make_blackhole
authorLi RongQing <roy.qing.li@gmail.com>
Mon, 17 Sep 2012 22:40:10 +0000 (22:40 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Sep 2012 20:30:15 +0000 (16:30 -0400)
if xfrm_policy_get_afinfo returns 0, it has already released the read
lock, xfrm_policy_put_afinfo should not be called again.

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/xfrm/xfrm_policy.c

index ab2ce7d5152d02803e81f149a3b496c738715f2d..387848e900783f6e6862c6d2c0b52ab45bbcfe50 100644 (file)
@@ -1764,7 +1764,7 @@ static struct dst_entry *make_blackhole(struct net *net, u16 family,
 
        if (!afinfo) {
                dst_release(dst_orig);
-               ret = ERR_PTR(-EINVAL);
+               return ERR_PTR(-EINVAL);
        } else {
                ret = afinfo->blackhole_route(net, dst_orig);
        }