[media] staging/media/go7007: Use kmemdup rather than duplicating its implementation
authorPeter Huewe <PeterHuewe@gmx.de>
Fri, 25 Jan 2013 22:23:30 +0000 (19:23 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 6 Feb 2013 11:05:07 +0000 (09:05 -0200)
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/staging/media/go7007/go7007-driver.c

index 0aaeb0aeb99eed6dd495f0fb2414fdccf4efff39..66950916df2311e189bf7df84db591a2c53905bb 100644 (file)
@@ -108,14 +108,13 @@ static int go7007_load_encoder(struct go7007 *go)
                return -1;
        }
        fw_len = fw_entry->size - 16;
-       bounce = kmalloc(fw_len, GFP_KERNEL);
+       bounce = kmemdup(fw_entry->data + 16, fw_len, GFP_KERNEL);
        if (bounce == NULL) {
                v4l2_err(go, "unable to allocate %d bytes for "
                                "firmware transfer\n", fw_len);
                release_firmware(fw_entry);
                return -1;
        }
-       memcpy(bounce, fw_entry->data + 16, fw_len);
        release_firmware(fw_entry);
        if (go7007_interface_reset(go) < 0 ||
                        go7007_send_firmware(go, bounce, fw_len) < 0 ||