drm/amd/powerplay: add error message to remind user updating firmware

Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Edward O'Callaghan <funfunctor@folklore1984.net>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
index 7a36a7404f738988a658b9e5b5ab0007dfd30f48..21b61315fc40a8f88e0fcfc0b1a9c0ffbf53a30c 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
@@ -369,8 +369,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
                        "Attempt to read SMC IF Version Number Failed!",
                        return -1);
 
-       if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
-               return -1;
+       if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
+               pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
+                      smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
+               return -EINVAL;
+       }
 
        return 0;
 }