drm/i915/dsi: lose the loose 666 format name in favor of packed
authorJani Nikula <jani.nikula@intel.com>
Wed, 16 Mar 2016 10:21:39 +0000 (12:21 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 16 Mar 2016 15:55:52 +0000 (17:55 +0200)
The enum mipi_dsi_pixel_format defines MIPI_DSI_FMT_RGB666 for the
"loose" 24 bpp format and MIPI_DSI_FMT_RGB666_PACKED for the 18 bpp
format. We have this the other way round, defining a loose version for
24 bpp.

Follow suit with what's in enum mipi_dsi_pixel_format to avoid future
confusion. Rename

VID_MODE_FORMAT_RGB666 -> VID_MODE_FORMAT_RGB666_PACKED
VID_MODE_FORMAT_RGB666_LOOSE -> VID_MODE_FORMAT_RGB666

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1458123700-16003-1-git-send-email-jani.nikula@intel.com
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/intel_dsi_pll.c

index 7dfc4007f3fa2aeeb31dcf5d173b34a77078f794..85ceec611412101204452e87caa6fc8706d9f772 100644 (file)
@@ -7887,8 +7887,8 @@ enum skl_disp_power_wells {
 #define  VID_MODE_FORMAT_MASK                          (0xf << 7)
 #define  VID_MODE_NOT_SUPPORTED                                (0 << 7)
 #define  VID_MODE_FORMAT_RGB565                                (1 << 7)
-#define  VID_MODE_FORMAT_RGB666                                (2 << 7)
-#define  VID_MODE_FORMAT_RGB666_LOOSE                  (3 << 7)
+#define  VID_MODE_FORMAT_RGB666_PACKED                 (2 << 7)
+#define  VID_MODE_FORMAT_RGB666                                (3 << 7)
 #define  VID_MODE_FORMAT_RGB888                                (4 << 7)
 #define  CMD_MODE_CHANNEL_NUMBER_SHIFT                 5
 #define  CMD_MODE_CHANNEL_NUMBER_MASK                  (3 << 5)
index 2451c84949bd0bdf072974bda0e799910e9b0bbb..9ef0f7806e4a8835865c42ecfe599dc4ffa6d127 100644 (file)
@@ -37,10 +37,10 @@ int dsi_pixel_format_bpp(int pixel_format)
        switch (pixel_format) {
        default:
        case VID_MODE_FORMAT_RGB888:
-       case VID_MODE_FORMAT_RGB666_LOOSE:
+       case VID_MODE_FORMAT_RGB666:
                bpp = 24;
                break;
-       case VID_MODE_FORMAT_RGB666:
+       case VID_MODE_FORMAT_RGB666_PACKED:
                bpp = 18;
                break;
        case VID_MODE_FORMAT_RGB565: