projects
/
GitHub
/
mt8127
/
android_kernel_alcatel_ttab.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b8356c4
)
ext4: Fix null bh pointer dereference in mballoc
author
Aneesh Kumar K.V
<aneesh.kumar@linux.vnet.ibm.com>
Sun, 10 Feb 2008 06:07:28 +0000
(
01:07
-0500)
committer
Theodore Ts'o
<tytso@mit.edu>
Sun, 10 Feb 2008 06:07:28 +0000
(
01:07
-0500)
Repoted by Adrian Bunk <bunk@kernel.org>:
The Coverity checker spotted the following NULL dereference:
static int ext4_mb_mark_diskspace_used
{
...
if (!bitmap_bh)
goto out_err;
...
out_err:
sb->s_dirt = 1;
put_bh(bitmap_bh);
...
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
fs/ext4/mballoc.c
patch
|
blob
|
blame
|
history
diff --git
a/fs/ext4/mballoc.c
b/fs/ext4/mballoc.c
index 76e5fedc0a0b4c7e581852d9eeab4374ba246a24..06d1f5292d3aa7395721a0a38e76fb3de7926cf8 100644
(file)
--- a/
fs/ext4/mballoc.c
+++ b/
fs/ext4/mballoc.c
@@
-3069,7
+3069,7
@@
static int ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac,
out_err:
sb->s_dirt = 1;
-
put_bh
(bitmap_bh);
+
brelse
(bitmap_bh);
return err;
}