X25: Fix oops and refcnt problems from x25_dev_get
authorandrew hendry <andrew.hendry@gmail.com>
Tue, 24 Nov 2009 15:16:05 +0000 (15:16 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 29 Nov 2009 08:25:02 +0000 (00:25 -0800)
Calls to x25_dev_get check for dev = NULL which was not set.
It allowed x25 to set routes and ioctls on down interfaces.
This caused oopses and refcnt problems on device_unregister.

Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/x25_route.c

index 66961ea28c91e093785cd3a85754a27661225d9e..b95fae9ab393976e682b245b537e8b9b6251e2d5 100644 (file)
@@ -136,8 +136,10 @@ struct net_device *x25_dev_get(char *devname)
 #if defined(CONFIG_LLC) || defined(CONFIG_LLC_MODULE)
                                        && dev->type != ARPHRD_ETHER
 #endif
-                                       )))
+                                       ))){
                dev_put(dev);
+               dev = NULL;
+       }
 
        return dev;
 }