pinctrl: sh-pfc: r8a7795: Simplify get bias logic

The last else statement is missing braces, and the indentation level can
be reduced.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 2e8cc2adbed7e2514096b9b75c4a9012d90066a4..6c585634a928ea756b39ae23789a4bc0b5e38d64 100644 (file)
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -5367,13 +5367,12 @@ static unsigned int r8a7795_pinmux_get_bias(struct sh_pfc *pfc,
        reg = pullups[pin].reg;
        bit = BIT(pullups[pin].bit);
 
-       if (sh_pfc_read_reg(pfc, PUEN + reg, 32) & bit) {
-               if (sh_pfc_read_reg(pfc, PUD + reg, 32) & bit)
-                       return PIN_CONFIG_BIAS_PULL_UP;
-               else
-                       return PIN_CONFIG_BIAS_PULL_DOWN;
-       } else
+       if (!(sh_pfc_read_reg(pfc, PUEN + reg, 32) & bit))
                return PIN_CONFIG_BIAS_DISABLE;
+       else if (sh_pfc_read_reg(pfc, PUD + reg, 32) & bit)
+               return PIN_CONFIG_BIAS_PULL_UP;
+       else
+               return PIN_CONFIG_BIAS_PULL_DOWN;
 }
 
 static void r8a7795_pinmux_set_bias(struct sh_pfc *pfc, unsigned int pin,