net: fix a sparse warning
authorAndy Zhou <azhou@nicira.com>
Mon, 6 Oct 2014 20:22:50 +0000 (13:22 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Oct 2014 04:10:47 +0000 (00:10 -0400)
Fix a sparse warning introduced by Commit
0b5e8b8eeae40bae6ad7c7e91c97c3c0d0e57882 (net: Add Geneve tunneling
protocol driver) caught by kbuild test robot:

  # apt-get install sparse
  #   git checkout 0b5e8b8eeae40bae6ad7c7e91c97c3c0d0e57882
  #     make ARCH=x86_64 allmodconfig
  #       make C=1 CF=-D__CHECK_ENDIAN__
  #
  #
  #       sparse warnings: (new ones prefixed by >>)
  #
  #       >> net/ipv4/geneve.c:230:42: sparse: incorrect type in assignment (different base types)
  #          net/ipv4/geneve.c:230:42:    expected restricted __be32 [addressable] [assigned] [usertype] s_addr
  #             net/ipv4/geneve.c:230:42:    got unsigned long [unsigned] <noident>
  #

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Andy Zhou <azhou@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/geneve.c

index f008c5515f48010d3f15657f2d4895bdbf1fe7e5..065cd94c640c0c2a20cbf99c31cba588db54897e 100644 (file)
@@ -227,7 +227,7 @@ static struct socket *geneve_create_sock(struct net *net, bool ipv6,
                udp_conf.family = AF_INET6;
        } else {
                udp_conf.family = AF_INET;
-               udp_conf.local_ip.s_addr = INADDR_ANY;
+               udp_conf.local_ip.s_addr = htonl(INADDR_ANY);
        }
 
        udp_conf.local_udp_port = port;