apparmor: Fix smatch warning in aa_remove_profiles

smatch reports
  error: potential NULL dereference 'ns'.

this can not actually occur because it relies on aa_split_fqname setting
both ns_name and name as null but ns_name will actually always have a
value in this case.

so remove the unnecessary if (ns_name) conditional that is resulting
in the false positive further down.

Signed-off-by: John Johansen <john.johansen@canonical.com>

diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c
index f4ee72b44de43facc777b910fa8629e3b60125fe..0f345c4dee5f46d7a6bb015d19105a0654a2f7d1 100644 (file)
--- a/security/apparmor/policy.c
+++ b/security/apparmor/policy.c
@@ -1156,14 +1156,12 @@ ssize_t aa_remove_profiles(char *fqname, size_t size)
        if (fqname[0] == ':') {
                char *ns_name;
                name = aa_split_fqname(fqname, &ns_name);
-               if (ns_name) {
-                       /* released below */
-                       ns = aa_find_namespace(root, ns_name);
-                       if (!ns) {
-                               info = "namespace does not exist";
-                               error = -ENOENT;
-                               goto fail;
-                       }
+               /* released below */
+               ns = aa_find_namespace(root, ns_name);
+               if (!ns) {
+                       info = "namespace does not exist";
+                       error = -ENOENT;
+                       goto fail;
                }
        } else
                /* released below */