[XFS] xfs_unmountfs should return void
authorChristoph Hellwig <hch@infradead.org>
Wed, 13 Aug 2008 06:49:57 +0000 (16:49 +1000)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Wed, 13 Aug 2008 06:49:57 +0000 (16:49 +1000)
xfs_unmounts can't and shouldn't return errors so declare it as returning
void.

SGI-PV: 981498

SGI-Modid: xfs-linux-melb:xfs-kern:31833a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/xfs_mount.c
fs/xfs/xfs_mount.h

index 06f0a73bc93fac881ee21ce0594a61b5dcdfe872..7f5027266ea051104b3ed9d72870f1ae39063cfe 100644 (file)
@@ -1229,16 +1229,15 @@ xfs_mountfs(
 }
 
 /*
- * xfs_unmountfs
- *
  * This flushes out the inodes,dquots and the superblock, unmounts the
  * log and makes sure that incore structures are freed.
  */
-int
-xfs_unmountfs(xfs_mount_t *mp)
+void
+xfs_unmountfs(
+       struct xfs_mount        *mp)
 {
-       __uint64_t      resblks;
-       int             error = 0;
+       __uint64_t              resblks;
+       int                     error;
 
        IRELE(mp->m_rootip);
 
@@ -1311,7 +1310,6 @@ xfs_unmountfs(xfs_mount_t *mp)
        xfs_errortag_clearall(mp, 0);
 #endif
        xfs_mount_free(mp);
-       return 0;
 }
 
 STATIC void
index 02c16b9ce2ab7fea6ab8e4c52fc8438d79987f66..f3c1024b1241ed8663568db7e309e75c83f866f0 100644 (file)
@@ -513,7 +513,7 @@ extern int  xfs_log_sbcount(xfs_mount_t *, uint);
 extern int     xfs_mountfs(xfs_mount_t *mp);
 extern void    xfs_mountfs_check_barriers(xfs_mount_t *mp);
 
-extern int     xfs_unmountfs(xfs_mount_t *);
+extern void    xfs_unmountfs(xfs_mount_t *);
 extern int     xfs_unmountfs_writesb(xfs_mount_t *);
 extern int     xfs_unmount_flush(xfs_mount_t *, int);
 extern int     xfs_mod_incore_sb(xfs_mount_t *, xfs_sb_field_t, int64_t, int);