powerpc/xive: Move a dereference below a NULL test
authorzhong jiang <zhongjiang@huawei.com>
Wed, 26 Sep 2018 12:09:32 +0000 (20:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 24 Nov 2019 07:23:01 +0000 (08:23 +0100)
[ Upstream commit cd5ff94577e004e0a4457e70d0ef3a030f4010b8 ]

Move the dereference of xc below the NULL test.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/sysdev/xive/common.c

index 818fc5351591cbacc82cd328419b6ba7c1510993..110d8bb16ebbb9652ac21f07cc27c5be4240e040 100644 (file)
@@ -1008,12 +1008,13 @@ static void xive_ipi_eoi(struct irq_data *d)
 {
        struct xive_cpu *xc = __this_cpu_read(xive_cpu);
 
-       DBG_VERBOSE("IPI eoi: irq=%d [0x%lx] (HW IRQ 0x%x) pending=%02x\n",
-                   d->irq, irqd_to_hwirq(d), xc->hw_ipi, xc->pending_prio);
-
        /* Handle possible race with unplug and drop stale IPIs */
        if (!xc)
                return;
+
+       DBG_VERBOSE("IPI eoi: irq=%d [0x%lx] (HW IRQ 0x%x) pending=%02x\n",
+                   d->irq, irqd_to_hwirq(d), xc->hw_ipi, xc->pending_prio);
+
        xive_do_source_eoi(xc->hw_ipi, &xc->ipi_data);
        xive_do_queue_eoi(xc);
 }