watchdog: orion: Remove unneeded BRIDGE_CAUSE clear
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Mon, 10 Feb 2014 23:00:26 +0000 (20:00 -0300)
committerJason Cooper <jason@lakedaemon.net>
Sat, 22 Feb 2014 03:43:36 +0000 (03:43 +0000)
After adding the IRQ request, the BRIDGE_CAUSE bit should be cleared by the
bridge interrupt controller. There's no longer a need to do it in the watchdog
driver, so we can simply remove it.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Tested-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Acked-by: Wim Van Sebroeck <wim@iguana.be>
Tested-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/watchdog/orion_wdt.c

index 6061b838d39658d3c0a3fa7e65d452f23ebc8993..65aa65560730abf0b087ea73c54d8e0e80057f0d 100644 (file)
@@ -24,7 +24,6 @@
 #include <linux/clk.h>
 #include <linux/err.h>
 #include <linux/of.h>
-#include <mach/bridge-regs.h>
 
 /* RSTOUT mask register physical address for Orion5x, Kirkwood and Dove */
 #define ORION_RSTOUT_MASK_OFFSET       0x20108
@@ -42,7 +41,6 @@
 #define WDT_MAX_CYCLE_COUNT    0xffffffff
 
 #define WDT_RESET_OUT_EN       BIT(1)
-#define WDT_INT_REQ            BIT(3)
 
 static bool nowayout = WATCHDOG_NOWAYOUT;
 static int heartbeat = -1;             /* module parameter (seconds) */
@@ -64,9 +62,6 @@ static int orion_wdt_start(struct watchdog_device *wdt_dev)
        /* Set watchdog duration */
        writel(wdt_tclk * wdt_dev->timeout, wdt_reg + WDT_VAL);
 
-       /* Clear watchdog timer interrupt */
-       writel(~WDT_INT_REQ, BRIDGE_CAUSE);
-
        /* Enable watchdog timer */
        atomic_io_modify(wdt_reg + TIMER_CTRL, WDT_EN, WDT_EN);