mrf24j40: Use level-triggered interrupts
authorAlan Ott <alan@signal11.us>
Sun, 6 Oct 2013 03:52:24 +0000 (23:52 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Oct 2013 19:32:14 +0000 (15:32 -0400)
The mrf24j40 generates level interrupts. There are rare cases where it
appears that the interrupt line never gets de-asserted between interrupts,
causing interrupts to be lost, and causing a hung device from the driver's
perspective.  Switching the driver to interpret these interrupts as
level-triggered fixes this issue.

Signed-off-by: Alan Ott <alan@signal11.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ieee802154/mrf24j40.c

index c1bc688363461a9e117f523ec7e3b42c3fb78422..0632d34905c73811456594cf0bf5e27f8710f5c7 100644 (file)
@@ -678,7 +678,7 @@ static int mrf24j40_probe(struct spi_device *spi)
        ret = request_threaded_irq(spi->irq,
                                   NULL,
                                   mrf24j40_isr,
-                                  IRQF_TRIGGER_FALLING|IRQF_ONESHOT,
+                                  IRQF_TRIGGER_LOW|IRQF_ONESHOT,
                                   dev_name(&spi->dev),
                                   devrec);