[media] rc: ite-cir: fix potential double free in ite_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Tue, 9 Apr 2013 08:43:53 +0000 (05:43 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 15 Apr 2013 00:37:53 +0000 (21:37 -0300)
Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/rc/ite-cir.c

index dd8237324c09429ab0f54ab424c9fe829c210be8..63b42252166a744fc2275b0b538a69bd4232f98d 100644 (file)
@@ -1613,6 +1613,7 @@ exit_release_cir_addr:
        release_region(itdev->cir_addr, itdev->params.io_region_size);
 exit_unregister_device:
        rc_unregister_device(rdev);
+       rdev = NULL;
 exit_free_dev_rdev:
        rc_free_device(rdev);
        kfree(itdev);