f2fs: fix memory leak of percpu counter in fill_super()
authorChao Yu <yuchao0@huawei.com>
Wed, 5 Sep 2018 06:54:02 +0000 (14:54 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 26 Oct 2018 18:21:45 +0000 (11:21 -0700)
In fill_super -> init_percpu_info, we should destroy percpu counter
in error path, otherwise memory allcoated for percpu counter will
leak.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/super.c

index bd8956692e12ac71c6509211ddc6d237e5e998e4..f321b99a72a770396236798ced9a26053290c46b 100644 (file)
@@ -2458,8 +2458,12 @@ static int init_percpu_info(struct f2fs_sb_info *sbi)
        if (err)
                return err;
 
-       return percpu_counter_init(&sbi->total_valid_inode_count, 0,
+       err = percpu_counter_init(&sbi->total_valid_inode_count, 0,
                                                                GFP_KERNEL);
+       if (err)
+               percpu_counter_destroy(&sbi->alloc_valid_block_count);
+
+       return err;
 }
 
 #ifdef CONFIG_BLK_DEV_ZONED