netfilter: xt_CT: don't put back reference to timeout policy object
authorPablo Neira Ayuso <pablo@netfilter.org>
Mon, 5 Oct 2015 14:51:03 +0000 (16:51 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 12 Oct 2015 14:54:45 +0000 (16:54 +0200)
On success, this shouldn't put back the timeout policy object, otherwise
we may have module refcount overflow and we allow deletion of timeout
that are still in use.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/xt_CT.c

index faf32d888198a72a50c293312c014bcb63747654..a03924c1db4102634e17d94a5f8466a6a6bb04d0 100644 (file)
@@ -171,6 +171,9 @@ xt_ct_set_timeout(struct nf_conn *ct, const struct xt_tgchk_param *par,
        if (timeout_ext == NULL)
                ret = -ENOMEM;
 
+       rcu_read_unlock();
+       return ret;
+
 err_put_timeout:
        __xt_ct_tg_timeout_put(timeout);
 out: