fotg210-udc: Don't DMA more than the buffer can take
authorFabian Vogt <fabian@ritter-vogt.de>
Wed, 24 Mar 2021 14:11:14 +0000 (15:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 May 2021 08:40:23 +0000 (10:40 +0200)
[ Upstream commit 3e7c2510bdfe89a9ec223dd7acd6bfc8bb1cbeb6 ]

Before this, it wrote as much as available into the buffer, even if it
didn't fit.

Fixes: b84a8dee23fd ("usb: gadget: add Faraday fotg210_udc driver")
Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de>
Link: https://lore.kernel.org/r/20210324141115.9384-7-fabian@ritter-vogt.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/udc/fotg210-udc.c

index 491b04dd6db716120022edfac314d10adbbb39c0..b2910bc65e5127856881272df3892ffa13bb3a77 100644 (file)
@@ -340,8 +340,9 @@ static void fotg210_start_dma(struct fotg210_ep *ep,
                } else {
                        buffer = req->req.buf + req->req.actual;
                        length = ioread32(ep->fotg210->reg +
-                                       FOTG210_FIBCR(ep->epnum - 1));
-                       length &= FIBCR_BCFX;
+                                       FOTG210_FIBCR(ep->epnum - 1)) & FIBCR_BCFX;
+                       if (length > req->req.length - req->req.actual)
+                               length = req->req.length - req->req.actual;
                }
        } else {
                buffer = req->req.buf + req->req.actual;