usb/net/r8152: fix integer overflow in expression
authorhayeswang <hayeswang@realtek.com>
Fri, 12 Jul 2013 08:26:15 +0000 (16:26 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Jul 2013 23:13:34 +0000 (16:13 -0700)
config: make ARCH=avr32 allyesconfig
drivers/net/usb/r8152.c: In function 'rtl8152_start_xmit':
drivers/net/usb/r8152.c:956: warning: integer overflow in expression

   955 memset(tx_desc, 0, sizeof(*tx_desc));
 > 956 tx_desc->opts1 = cpu_to_le32((len & TX_LEN_MASK) | TX_FS | TX_LS);
   957 tp->tx_skb = skb;

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Spotted-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index d02bac82fc5759df00a8bfab5907e29f92be722c..ee13f9eb740c0bf18b793b308194675e9967a317 100644 (file)
@@ -934,7 +934,8 @@ static netdev_tx_t rtl8152_start_xmit(struct sk_buff *skb,
        struct r8152 *tp = netdev_priv(netdev);
        struct net_device_stats *stats = rtl8152_get_stats(netdev);
        struct tx_desc *tx_desc;
-       int len, res;
+       unsigned int len;
+       int res;
 
        netif_stop_queue(netdev);
        len = skb->len;